Plotting an indicator that includes a benchmark symbol

mikesblack

#1

1/19/2016 9:46 PM

Hi I am unable to have the following code create a chart that includes a new symbol which was calculated. I called this (indicatot)r as seen below. Can you help me solve this?

You declared "Bars Benchhmark;" but didn't do anything with it. It's just a Bars object with 0 bars and nothing else either.

Re:
DataSeries newMax = newMax(Benchmark.Close, 25);

First, Benchmark is not defined anywhere. Previously you had declared "Benchhmark".. note the spelling difference!

Second, you declared newMax to be a DataSeries (DataSeries newMax) but in the same statement you're trying to call newMax as a function, i.e., newMax(Benchmark.Close, 25);

What is the "newMax()" method call suppose to do with an empty Bars object and the integer parameter 25? And where is this function defined?

mikesblack

#3

1/20/2016 12:57 PM

Thanks Cone,

I'll need to work through it. Do you have any resources or hints that can help me? If you are unclear about what I wish to do, please let me explain.

I want to create an indicator based off of an external symbol. // This is the Bearx fund.
Then add an indicator, newMax(c, 25) to that external symbol.
Next =>
Take the avgFriClose indicator that is based off of the symbol selected, and multiply that value with the value above.// newMax( Bearx C, 25)
That is called indicator.
indicator = avgFriClose(JPM C, 5) * newMax( Bearx C, 25)
Next=> Plot indicator

Ultimately I wish to build a trading system around this.
Thanks for your time.

Eugene

#4

1/20/2016 1:06 PM

As it's a popular question I'm sure you'll find plenty of pointers. Just last week I answered a similar query.

+ GetExternalSymbol in the QuickRef
+ WealthScript Programming Guide > DataSeries > Accessing Secondary Symbols
+ downloadable strategies inside WLP's "Intermarket" folder
+ External Symbol with Indicator - re: operations with external symbol's data
+ many examples by prefixing your Google search query with "site:wealth-lab.com" e.g. GetExternalSymbol

mikesblack

#5

1/20/2016 3:00 PM

Eugene Great ideas. Thanks!

Look below. When I add lines

none of the charts show up; however if I comment these lines and replace Benchmark.Close with Close, I'll get both charts to show, but ONLY for the symbol selected. What I wish to do eventually is as I described in the last post is to plot the two indicators multiplied together. For now, I wish to plot the avgFri indicator for JPM and the NewMax for Bearx.
I'll look at the references you posted.

Thanks,
Mike

Size:

Color:

Eugene Great ideas. Thanks!

Look below. When I add lines [code]string       BenchmarkSymbol                    = "BEARX";
	    Bars         Benchmark                          = GetExternalSymbol( "JPM BEARX", BenchmarkSymbol, true );[/code] none of the charts show up; however if I comment these lines and replace Benchmark.Close with Close, I'll get both charts to show, but ONLY for the symbol selected. What I wish to do eventually is as I described in the last post is to plot the two indicators multiplied together. For now, I wish to plot the avgFri indicator for JPM and the NewMax for Bearx. 
 I'll look at the references you posted.

Thanks,
Mike

[code]using System;
using System.Collections.Generic;
using System.Text;
using System.Drawing;
using WealthLab;
using WealthLab.Indicators;

//Pushed indicator using statements
using Community.Indicators;
namespace WealthLab.Strategies
{
	public class MyStrategy : WealthScript
	{
		//Pushed indicator StrategyParameter statements
		string       BenchmarkSymbol                    = "BEARX";
	    Bars         Benchmark                          = GetExternalSymbol( "JPM BEARX", BenchmarkSymbol, true );
		private StrategyParameter slider1;
		public MyStrategy()
		{
			//Pushed indicator CreateParameter statements
			slider1 = CreateParameter("NewMax_Period_1",25,2,300,20);

}
		protected override void Execute()
		{
			DataSeries friClose = Close*0;
         
			for(int bar = 1; bar < Bars.Count; bar++)
			{
				if (Date[bar].DayOfWeek == DayOfWeek.Friday )
				{
					friClose[bar] = Close[bar] > Open[bar] ? 1 : 0;
				}
				else
					friClose[bar] = friClose[bar - 1];
			}
         
			DataSeries avgFriClose = SMA.Series( friClose, 5 );
         
			ChartPane p = CreatePane( 30,false,true );
			PlotSeries( p, avgFriClose, Color.Blue, WealthLab.LineStyle.Solid, 1 );
			HideVolume();         
			//Pushed indicator ChartPane statements
			ChartPane paneNewMax1 = CreatePane(25,true,true);

//Pushed indicator PlotSeries statements
			PlotSeries(paneNewMax1,NewMax.Series(BenchmarkClose,25),Color.FromArgb(255,0,128,0),LineStyle.Solid,2);

}
	}
}
[/code]

Eugene

#6

1/20/2016 3:26 PM

None of the examples instructs to use GetExternalSymbol in a class level variable. If examples sparsely use class level variables in general, this must be for a purpose. Don't use class level variables in WealthScript strategies unless you really know what you're doing. This affects system behavior. You don't want that happening in your particular case:

mikesblack

#7

1/20/2016 10:26 PM

Eugene, Ill start with the materials you suggested. Seems I need time to become familiar with what seems like an easy task. I'm frustrated feeling stuck.
Have you put on record the extent of help you will supply. E.g writing code. This will help me formulate the question I pose in the future. You guys are a good resource and hope not to become to become a nuisance.

Eugene

#8

1/21/2016 2:33 AM

Okay here you go. Hope this quick example helps you become familiar with external symbols, their DataSeries, etc.:

mikesblack

#9

1/23/2016 2:01 AM

Thanks Eugene,

That is very helpful. I appreciate your help with this example.. I have committed my time to read through the weathlab script manual. It will take a bit of time,but so far I am beginning to understand the material. I realize it will take time working through examples, but clearly this is what I should have done years ago when starting to work with the program. Now with a solid base of understanding from my C# classes, the material makes much more sense. Let me know by p.m. if you feel I am asking for too much help. I would like to cooperate with you guys and contribute to this forums in the future.

Mike

Eugene

#10

1/24/2016 3:46 PM

In a duplicate thread that directly resulted from this topic and for that reason has been deleted, mikesblack asked:

Hi Eugene,

Following my "NewMaxBearx-AvgFriClose, I added trading rules. Unfortunately the system does not work. When you have a chance, will you look at my code below to help get this system to work?

Thanks,
Mike

Size:

Color:

In a duplicate thread that directly resulted from this topic and for that reason has been deleted, [size=1]mikesblack[/size] asked:

Hi Eugene,

Following my "NewMaxBearx-AvgFriClose, I added trading rules. Unfortunately the system does not work. When you have a chance, will you look at my code below to help get this system to work?

Thanks,
Mike

[code]using System;
using System.Collections.Generic;
using System.Text;
using System.Drawing;
using WealthLab;
using WealthLab.Indicators;
using Community.Indicators;

namespace WealthLab.Strategies
{
	public class NewMaxStrategy : WealthScript
	{			
		private StrategyParameter slider1;
		
		public NewMaxStrategy()
		{			
			slider1 = CreateParameter("NewMax Period",25,2,300,20);
		}
		
		protected override void Execute()
		{
			string  BenchmarkSymbol  = "BEARX";
			Bars  Benchmark  = GetExternalSymbol( "JPM BEARX", BenchmarkSymbol, true );
			var BenchmarkClose = Benchmark.Close;
			var newMax = NewMax.Series(BenchmarkClose, 25);
			
			DataSeries friClose = Close*0;
         
			for(int bar = 1; bar < Bars.Count; bar++)
			{
				if (Date[bar].DayOfWeek == DayOfWeek.Friday )
				{
					friClose[bar] = Close[bar] > Open[bar] ? 1 : 0;
				}
				else
					friClose[bar] = friClose[bar - 1];
			}
         
			var avgFriClose = SMA.Series(friClose, 5);
			var indicator = avgFriClose * newMax;
			
			// To do: Write code for sell and buy rules.
			int numberOfBars = 5;	
			
			for(int bar = 40; bar < Bars.Count; bar++)
			{
				if(IsLastPositionActive)
				{
					Position p = LastPosition;
					if( indicator > 0)
						ExitAtMarket( bar + 1, p);
				}
				
									
					//	if( IsLastPositionActive)
					//	{
					//		Position p = LastPosition;
					//		if( bar + 1 - p.EntryBar >= numberOfBars)
					//			ExitAtMarket( bar + 1, p);
					//	}
					
				else
				{
					if( indicator < 0)
					{
						BuyAtMarket(bar + 1, p);
					}
				}
				
			}
			HideVolume();
			
			// plot avgFriClose-default dataseries
			ChartPane p = CreatePane( 30,false,true );
			PlotSeries( p, avgFriClose, Color.Blue, WealthLab.LineStyle.Solid, 1 );
			         
			// plot NewMax- Bearx
			ChartPane paneNewMax1 = CreatePane(25,true,true);
			PlotSeries(paneNewMax1, newMax, Color.FromArgb(255, 0, 128, 0), LineStyle.Solid,2);
			
			// plot indicator(NewMax*newMax)
			ChartPane pi = CreatePane(30,false,true);
			PlotSeries(pi,indicator,Color.Red, WealthLab.LineStyle.Solid,1);
		
		}
	}
}
[/code]

mikesblack

#11

1/24/2016 6:28 PM

Code revision compiles, runs , plots the indicator "ind" = avgFriClase * newMax; but produces no trades. Why?

Size:

Color:

Code revision compiles, runs , plots the indicator "ind" = avgFriClase * newMax; but produces no trades. Why?

[code]

using System;
using System.Collections.Generic;
using System.Text;
using System.Drawing;
using WealthLab;
using WealthLab.Indicators;
using Community.Indicators;

namespace WealthLab.Strategies
{
	public class NewMaxStrategy : WealthScript
	{
			private StrategyParameter slider1;

public NewMaxStrategy()
			{
				slider1 = CreateParameter("NewMax Period", 25, 2, 300, 20);
			}

protected override void Execute()
		{
			string BenchmarkSymbol = "BEARX";
			Bars Benchmark = GetExternalSymbol("JPM BEARX", BenchmarkSymbol, true);
			var BenchmarkClose = Benchmark.Close;
			var newMax = NewMax.Series(BenchmarkClose, 25);

DataSeries friClose = Close * 0;

for (int bar = 1; bar < Bars.Count; bar++)
			{
				if (Date[bar].DayOfWeek == DayOfWeek.Friday)
				{
					friClose[bar] = Close[bar] > Open[bar] ? 1 : 0;
				}
				else
					friClose[bar] = friClose[bar - 1];
			}

var avgFriClose = SMA.Series(friClose, 5);
			var ind = avgFriClose * newMax;
			
			
			HideVolume();

// plot avgFriClose-default dataseries
		//	ChartPane p = CreatePane(30, false, true);
		//	PlotSeries(p, avgFriClose, Color.Blue, WealthLab.LineStyle.Solid, 1);

// plot NewMax- Bearx
		//	ChartPane paneNewMax1 = CreatePane(25, true, true);
		//	PlotSeries(paneNewMax1, newMax, Color.FromArgb(255, 0, 128, 0), LineStyle.Solid, 2);

// plot indicator
			ChartPane pi = CreatePane(30, false, true);
			PlotSeries(pi, ind, Color.Red, WealthLab.LineStyle.Solid, 1);

// To do: Write code for sell and buy rules.

for (int bar = GetTradingLoopStartBar(100); bar < Bars.Count; bar++)
			{
				if (IsLastPositionActive)
				{
					Position p = LastPosition;
				
				
					if (p.EntrySignal.Contains("Group1|"))
					{
					 
						if ( ind[bar] >= 0.0)
						{
							SellAtMarket(bar + 1, p, "Group1|");

}
			
					}
					else
					{
						if (ind[bar] < 0.0)
						{
							BuyAtMarket(bar + 1, "Group1|");

}
					}
				}
	        
		    	}
			}
		}
	}

[/code]

Eugene

#12

1/25/2016 1:55 AM

Carefully review how your trading logic is aligned with regard to the curly braces. The placement is wrong.

Neither troubleshooting custom code nor system modifications or free tutorship are a part of the support deal. So that a technician's attention isn't monopolized when assisting with custom code, asking thoughtful questions and providing detailed error reports is a sign that the user makes some real effort. For your future reference, here's how.

As "doesn't work" just doesn't work for us, this mind-opening reading should help see things from a technician's perspective: How to Report Bugs Effectively > "It doesn't work". If there's an error, notice what the Editor's message frame or Debug window is telling you. Don't hesitate to look that error up in MSDN. Chances are you'll get it solved; otherwise you provide technicians something to work with. In relevant cases it makes sense to specify such details as single symbol or multi-symbol mode, position sizing, data loading settings, symbol(s) and data provider etc.

mikesblack

#13

1/25/2016 10:56 AM

Thanks Eugene. I understand , appreciate your response and your needs. Thank you for the link and information about reporting bugs effectively. I expect that in time you will see proper etiquette and proper communications from me. In addition, I will curtail questions to only those that are relevant as per examples from other users on this forum. I shouldn't have expected you or Robert to provide extra tutoring. My apologies for crossing that line with the last few posts. As I am on break for a while from school( we have decided to move to Portland and temporally taking time off until we become established ), I have dedicated a great deal of time to learning Wealth Lab and testing ideas I had not had the opportunity to test as I was fully committed to my school work. My over zealousness perhaps made me somewhat careless about the kind of help you or Cone should provide me.

Thank you for your feedback regarding the logic as it pertains to the placement of curly braces. In addition thank you guys for the services you provide. Wealth Lab is an awesome tool and is even more amazing than when I started many years ago.

Eugene

#14

1/25/2016 11:52 AM

Re: curly braces. I meant to say that the whole logic, buy and sell, goes inside the IsLastPositionActive block - leaving no chance for a buy. Hope this helps.

mikesblack

#15

1/25/2016 12:29 PM

Thank you very much for that Eugene. I'm sure it will.

mikesblack

#16

1/25/2016 12:39 PM

I used an example from the drag and drop to use to help me with this. Intuitively it makes sense; however applying this code on a single symbol or an index produces no buys or sells; however it compiles without error and plots the indicators. I hope that I understand your suggestion. Am I on track?

Eugene

#17

1/25/2016 1:28 PM

No, you're not. Error is not fixed: the entire logic is still locked inside the IsLastPositionActive block. You'll find details about this and "single position strategy template", which is a cornerstone of strategy creation, in the WealthScript Guide and QuickRef. Carefully compare the structure of your code with every other single-position code that is known to work until you're through with it.

mikesblack

#18

1/25/2016 2:31 PM

Thanks Eugene, I actually just met with my C# professor over coffee and asked her about it. I now understand that the if(IsLastPositionActive) should only include the sell signal and not the buy signal. That is as simple as placing one more curly brace after the sell condition. The program is now producing trades. We'll see if it makes money ;). Thanks again for your feedback and for going above and beyond. That is very much appreciated. Lot's to learn, which will take time, but I am excited to learn all the new features of Wealth Lab. Hope you have a great week.

BTW , we just accepted a counter offer from the seller and should be closing on our new house in just a couple of weeks. Lots of exciting but busy times ahead for us..